sqozz/sem6000
2
2
Fork 3
Code Issues Pull requests Releases Wiki Activity

Collectd Plugin #13

Merged
sqozz merged 3 commits from cfr34k/sem6000:collectd into master 2020-05-02 19:26:20 +02:00
Conversation 1 Commits 3 Files changed 2 +2 -2
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 861079e997 - Show all commits

4
collectd/collectd_sem6000.py
View file

@ -7,7 +7,7 @@ import time
import collectd import collectd
from sem6000 import SEMSocket from sem6000 import SEMSocket
import bluepy from bluepy.btle import BTLEDisconnectError
sqozz commented 2020-01-21 09:13:58 +01:00
Outdated
Review
Copy link

maybe just import the exception here? I don't know if it makes any performance difference but at least it would be less confusing why bluepy is needed in here.

maybe just import the exception here? I don't know if it makes any performance difference but at least it would be less confusing why bluepy is needed in here.
cfr34k commented 2020-01-21 19:45:37 +01:00
Outdated
Review
Copy link

Sounds reasonable. I'll do that!

Sounds reasonable. I'll do that!
instances = [] instances = []
@ -75,7 +75,7 @@ def read_func():
collectd.info("sem6000: Connected.") collectd.info("sem6000: Connected.")
inst['socket'].getStatus() inst['socket'].getStatus()
except (SEMSocket.NotConnectedException, bluepy.btle.BTLEDisconnectError, BrokenPipeError) as e: except (SEMSocket.NotConnectedException, BTLEDisconnectError, BrokenPipeError) as e:
collectd.warning("sem6000: Exception caught: {}".format(e)) collectd.warning("sem6000: Exception caught: {}".format(e))
collectd.warning("sem6000: Restarting on next cycle...") collectd.warning("sem6000: Restarting on next cycle...")